-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(composed-modal): pass ref to ComposedModal and parts #10542
feat(composed-modal): pass ref to ComposedModal and parts #10542
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 2d52389 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620d46d9ba00fe0007f622a9 😎 Browse the preview: https://deploy-preview-10542--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2d52389 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620d46d9f54ac9000865a614 😎 Browse the preview: https://deploy-preview-10542--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 2d52389 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620d46d9ba00fe0007f622a4 😎 Browse the preview: https://deploy-preview-10542--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for mirroring the changes in next
for v11!
Closes #10543
A simple PR to add refs to the ComposedModal, ModalHeader, ModalBody, and ModalFooter components. We have a need to measure the content and automatically adjust the size of the modal based on the available space and the used space. This simplifies that process significantly.
Changelog
New
Testing / Reviewing
Confirm the unit tests are sufficient to confirm ref are passed and working