-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stylelint): update stylelint to 14.3.0 #10637
Conversation
Note for reviewers: Do we want to disable the rules that are now throwing lint errors? |
@tw15egan great point, I think some of them may need to be configured per-directory, like:
For ones that are unknown, definitely feel free to remove them (like |
4dbebce
to
9cd5c08
Compare
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 3f9fb43 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620bea684e80040008edeab1 😎 Browse the preview: https://deploy-preview-10637--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 3f9fb43 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620bea6811e5b50008cc2f1f 😎 Browse the preview: https://deploy-preview-10637--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9cd5c08 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fc42881e903c00077dda5a 😎 Browse the preview: https://deploy-preview-10637--carbon-components-react.netlify.app/ |
@joshblack do you have any examples on how to disable in one package but not the others? Would that be made in |
@tw15egan I think we would use overrides for this: https://stylelint.io/user-guide/configure#overrides Let me know if that works! |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 3f9fb43 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620bea6867eaf80007a2cfab 😎 Browse the preview: https://deploy-preview-10637--carbon-components-react.netlify.app |
b5705ce
to
f90f864
Compare
@joshblack Got it worked out, good to go now if you want to take another look |
@@ -330,11 +330,11 @@ $button-disabled: ( | |||
), | |||
( | |||
theme: themes.$g90, | |||
value: rgba(141, 141, 141, 0.3), | |||
value: rgb(141 141 141 / 30%), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the rgb
approach preferred moving forward?? Pretty cool format 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I had originally modified it to that format, but I was getting compilation errors when running the style tests. Any ideas on how to get around that?
2db7160
to
3f1318e
Compare
ff4697b
to
6e581ef
Compare
6e581ef
to
3f9fb43
Compare
Noticed there was a message about
stylelint
v13 being deprecated in VSCode, so I've gone and updated us to v14.3.0.Reference:
Migration:
Changelog
New
stylelint
now extendsstylelint-config-standard-scss
Changed
stylelint
from13.13
to14.3
Testing / Reviewing
Ensure no warning pops up in the bottom right corner of VS Code when opening the Carbon repo.
Ensure
stylelint
validations still appear as usual