Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logging for DNS resolver (also fixes #1417) #1436

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

Sculas
Copy link
Contributor

@Sculas Sculas commented Oct 4, 2023

This PR implements logging for the DNS resolver, but also accidentally fixes issue #1417 due to a bug in default_net (as far as I'm aware, see #1417 (comment)).

Fixes #1417

crates/binstalk-downloader/src/remote/resolver.rs Outdated Show resolved Hide resolved
crates/binstalk-downloader/src/remote/resolver.rs Outdated Show resolved Hide resolved
crates/binstalk-downloader/src/remote/resolver.rs Outdated Show resolved Hide resolved
@Sculas Sculas requested a review from NobodyXu October 5, 2023 10:44
@NobodyXu
Copy link
Member

NobodyXu commented Oct 5, 2023

CI failure is spurious, I will retry it.

@NobodyXu NobodyXu added this pull request to the merge queue Oct 5, 2023
Merged via the queue into cargo-bins:main with commit af04e45 Oct 5, 2023
25 checks passed
@Sculas Sculas deleted the dns-adapter-fix branch October 5, 2023 11:36
@NobodyXu
Copy link
Member

NobodyXu commented Oct 5, 2023

Thank you @Sculas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: v1.3.1 stopped working with VPN on
2 participants