Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duotones on color options page #42

Open
glerner opened this issue May 11, 2023 · 1 comment
Open

Duotones on color options page #42

glerner opened this issue May 11, 2023 · 1 comment

Comments

@glerner
Copy link

glerner commented May 11, 2023

https://fullsiteediting.com/lessons/theme-json-color-options/
theme.json works as described, so I'm guessing the issue is how duotones are (not?) applied on that page.

Probably good to mention on this page that to apply a duotone, use the image block's "hover menu" circle icon.
I thought my theme.json duotone section was incorrect, since doutone didn't appear in the image block settings.

I would like to see Duotone as part of the Image Block settings panel, just like background color and gradient are for paragraphs and columns. (I know that is not a theme.json question...)

Is there a way to specify duotone for featured images in theme.json, maybe with a setting per page for which duotone to use? https://wordpress.org/themes/wei/ does this.

p.s. Here's the duotones I am defining (using the hex color codes for my primary and secondary dark colors and lightened versions of them).
"duotone": [
{
"colors": [ "#000000", "#ffffff" ],
"slug": "duotone-foreground-and-background",
"name": "Foreground"
},
{
"colors": [ "#0068a7", "#9ddbed" ],
"slug": "doutone-primary",
"name": "Primary"
},
{
"colors": [ "#20828c", "#cfe7c7" ],
"slug": "duotone-secondary",
"name": "Secondary"
},
{
"colors": [ "#0068a7", "#cfe7c7" ],
"slug": "primary-and-secondary",
"name": "Primary and Secondary"
}
],

@carolinan
Copy link
Owner

Hi
I am struggling to understand what is asked here.
No, theme.json does not have any per-page or per-post settings.
Yes, you themes can add custom controls, you can use the Wei theme as an example and copy code from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants