Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expiry date in theme set-cookie #141

Merged
merged 1 commit into from Oct 20, 2023
Merged

Fix expiry date in theme set-cookie #141

merged 1 commit into from Oct 20, 2023

Conversation

timhawes
Copy link
Contributor

Description:

The theme cookie has an invalid expires date:

Set-Cookie:  theme=light; expires=time.struct_time(tm_year=2024, tm_mon=10, tm_mday=19, tm_hour=9, tm_min=22, tm_sec=51, tm_wday=5, tm_yday=293, tm_isdst=0); Path=/

With fix:

Set-Cookie:  theme=light; expires=Sat, 19 Oct 2024 09:22:58 GMT; Max-Age=31536000; Path=/

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

@caronc
Copy link
Owner

caronc commented Oct 20, 2023

🙏 Thank you!

@caronc caronc merged commit 36e5d75 into caronc:master Oct 20, 2023
1 check passed
@timhawes timhawes deleted the fix_set_cookie branch October 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants