Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-ignored-replay-buffer doesn't check bufferSize if object config passed to shareReplay #100

Open
sashaqred opened this issue May 1, 2022 · 0 comments · May be fixed by #114
Open

no-ignored-replay-buffer doesn't check bufferSize if object config passed to shareReplay #100

sashaqred opened this issue May 1, 2022 · 0 comments · May be fixed by #114

Comments

@sashaqred
Copy link

In my project I'm using plugin:rxjs/recommended which comes with two rules: rxjs/no-sharereplay and rxjs/no-ignored-replay-buffer.

The following code is good with rxjs/no-ignored-replay-buffer rule and throws error with rxjs/no-sharereplay rule:

interval(1000).pipe(shareReplay(1));

And this won't throw any linter error:

interval(1000).pipe(shareReplay({refCount: true}));

But bufferSize here is missing. And it looks like here should be error from rxjs/no-ignored-replay-buffer rule. I've checked sources and it looks like the rule check only arguments length but doesn't check the arguments content.

Also, I can help with pull request, if you don't mind.

skrtheboss added a commit to skrtheboss/eslint-plugin-rxjs that referenced this issue May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant