Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rxjs/finnish throws false errors with combineLatest #115

Open
distante opened this issue May 24, 2023 · 0 comments
Open

[BUG] rxjs/finnish throws false errors with combineLatest #115

distante opened this issue May 24, 2023 · 0 comments

Comments

@distante
Copy link

Plugin version: 5.0.3
rxjs Version: 7.8.1

combineLatest can also take an object as key/observable that makes easier to maintain the observable since the order is not important anymore when spreading the values.

So instead of

combineLatest([obs1$, obs2$]).pipe(
    map(([obs1, obs2]) => {
     // do something
    })
)

we can do

combineLatest({
  obs1: obs1$,
  obs2: obs2$
}).pipe(
    map(({obs2, obs1}) => { // note that the order is backwards, but it is ok here.
     // do something
    })
)

The problem is that rxjs/finnish will detect obs1: obs1$, and obs2: obs2$ as an error with Finnish notation should be used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant