Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector Observable #84

Open
spaceribs opened this issue Oct 7, 2020 · 4 comments
Open

Selector Observable #84

spaceribs opened this issue Oct 7, 2020 · 4 comments

Comments

@spaceribs
Copy link
Contributor

Hi,

I have a combiner I've been shopping around for the right place to contribute to, I didn't notice anything in your library which appeared to do the same, but this seems like the appropriate place for such a thing:

https://gist.github.com/spaceribs/738ec30dac2874d5ba9f7718208410e9

Please take a look and let me know if it makes sense to put up a pull request for this feature.

@cartant
Copy link
Owner

cartant commented Oct 26, 2020

Sorry, this slipped off my radar. I'll try to have a look at it later this week.

@cartant
Copy link
Owner

cartant commented Nov 9, 2020

That sounds reasonable, to me, but, IMO, it needs a better name. I think, selector too general and doesn't really convey what it does. I appreciate that naming things is hard. Given that it's close to onErrorResumeNext maybe something like onErrorResumeNextUntilComplete? IDK, that's pretty long. 😅 If you can come up with a name that's more descriptive than selector, I'm fine with adding it to the package.

Maybe onErrorContinue? IDK. Naming things is hard. 🤷‍♂️

@spaceribs
Copy link
Contributor Author

spaceribs commented Nov 9, 2020

Agreed that selector isn't a good name, I just grabbed that from behavior tree nomenclature. Heres yours and my suggestions combined:

  1. onErrorContinue
  2. resumeUntilComplete
  3. percolate - i'm actually kind of a fan on this one. If you view the execution as a tree, then success is viewed on the ability of getting from the root to the leaves. If you already understand that basic algorithms exercise, that's exactly what this is doing.

let me know what you think of that last one, personally I like the idea of making it rather low level sounding because at least to me, percolates OR complements concats AND behavior

@cartant
Copy link
Owner

cartant commented Nov 9, 2020

I'm fine with percolate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants