Skip to content

Commit 8acf083

Browse files
committedJul 13, 2021
fix: Pass errors to done in Jest.
1 parent f44dbe3 commit 8acf083

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed
 

‎fixtures/jest/passing-spec.ts

-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ describe("marbles", () => {
7676
m.flush();
7777

7878
expect(done).toBeInstanceOf(Function);
79-
expect(done.fail).toBeInstanceOf(Function);
8079
setTimeout(done, 0);
8180
})
8281
);

‎source/jest/observe.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,13 @@
66
import { Observable } from "rxjs";
77
import { DoneSubscriber } from "../done-subscriber";
88

9-
export interface DoneFunction {
10-
(): void;
11-
fail: (error: any) => void;
12-
}
9+
export type DoneFunction = (error?: Error) => void;
1310

1411
export function observe<T>(
1512
observableTest: () => Observable<T>
1613
): (done: DoneFunction) => void {
1714
return (done: DoneFunction) => {
18-
const subscriber = new DoneSubscriber(done.fail, done);
15+
const subscriber = new DoneSubscriber(done, done);
1916
observableTest().subscribe(subscriber);
2017
};
2118
}

0 commit comments

Comments
 (0)
Please sign in to comment.