Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update express-eval dependency to v5 #400

Merged
merged 2 commits into from Dec 2, 2022
Merged

Conversation

Th3Whit3Wolf
Copy link
Contributor

@Th3Whit3Wolf Th3Whit3Wolf commented Dec 1, 2022

I'm not sure if this issue affects node-casbin but node-casbin is causing CI dependency check issues for me because of it. I hope you won't mind accepting my PR.

@casbin-bot
Copy link
Member

@nodece @Zxilly @Shivansh-yadav13 please review

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2022

CLA assistant check
All committers have signed the CLA.

@Th3Whit3Wolf Th3Whit3Wolf changed the title Security: Update express-eval chore(deps): Update express-eval Dec 1, 2022
@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 3598868534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.108%

Totals Coverage Status
Change from base Build 3588878735: 0.0%
Covered Lines: 1414
Relevant Lines: 1744

💛 - Coveralls

package.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@hsluoyz
Copy link
Member

hsluoyz commented Dec 2, 2022

@nodece can you make a PR instead? what this PR does is very simple

@hsluoyz hsluoyz changed the title chore(deps): Update express-eval fix: update express-eval dependency to v5 Dec 2, 2022
@nodece nodece merged commit 02a9496 into casbin:master Dec 2, 2022
github-actions bot pushed a commit that referenced this pull request Dec 2, 2022
## [5.19.3](v5.19.2...v5.19.3) (2022-12-02)

### Bug Fixes

* update express-eval dependency to v5 ([#400](#400)) ([02a9496](02a9496))
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

🎉 This PR is included in version 5.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants