From 3dc0aa9ce6cddd50ffae2a020b2e261656e04657 Mon Sep 17 00:00:00 2001 From: Stefan <5585744+casdevs@users.noreply.github.com> Date: Mon, 2 Nov 2020 09:10:07 +0100 Subject: [PATCH] Update definitions.ts I noticed that `updateTypes: ['patch']` only matches if `separateMinorPatch` is set to true. This comes somewhat unexpected and does not seem to be documented anywhere at the moment, as opposed to the documentation of the `patch` setting, where the docs correctly state `Only applies if separateMinorPatch is set to true`. Maybe related to https://github.com/renovatebot/renovate/issues/2818 But without reading the docs, I would expect `updateTypes: ['patch']` to always match on patch updates (e.g. 1.0.0 to 1.0.1) regardless of the `separateMinorPatch` setting (which is only set if we want separate PRs or branches for patch AND minor updates) --- lib/config/definitions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts index 3d50d2369e01c8..ad449ca4a98b7c 100644 --- a/lib/config/definitions.ts +++ b/lib/config/definitions.ts @@ -900,7 +900,7 @@ const options: RenovateOptions[] = [ { name: 'updateTypes', description: - 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object.', + 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. `patch` only matches if `separateMinorPatch` is set to true', type: 'array', // TODO: add allowedValues subType: 'string',