Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to this issue to get requests for user feedback! #1202

Open
casey opened this issue May 28, 2022 · 5 comments
Open

Subscribe to this issue to get requests for user feedback! #1202

casey opened this issue May 28, 2022 · 5 comments

Comments

@casey
Copy link
Owner

casey commented May 28, 2022

Please subscribe to this issue if you'd like to receive notifications for requests for user feedback.

Situations often arise in which user feedback would be very helpful. Some examples are:

  • Questions about whether a potential new feature is worth it or not.
  • Questions about how a new feature should be implemented.
  • Issues concerning existing features that I don't use.
  • Issues concerning Windows, since I use Unix machines personally, and don't have a lot of Windows dev experience.
  • Weird edge-cases where I can't figure out whether something is a bug and should be fixed, even if it might break existing justfiles.

If you're interested in helping out, subscribe to this issue! This issue is locked, so the only notifications that you'll get will be requests for help from me. I'll always link to another issue, and keep commentary out of this thread, so it should be focused.

Repository owner locked as spam and limited conversation to collaborators May 28, 2022
@casey casey pinned this issue May 28, 2022
@casey
Copy link
Owner Author

casey commented May 28, 2022

First request: Check out #1201 for a proposal for a backwards-compatible way of introducing otherwise breaking changes. Tell me what you think. Is this a good idea? Is there a better way to do it? Are there any pitfalls I haven't thought of? Will it be super annoying if people have to put set edition := 2 to get better defaults?

@casey
Copy link
Owner Author

casey commented May 28, 2022

Second request: Initially, just used sh on all platforms. This required installing sh on Windows, but made justfiles work the same everywhere. Later, the set windows-powershell setting was introduced, which allowed using powershell.exe on Windows but sh everywhere else. PowerShell and sh are often compatible, so this was a good way of writing cross-platform justfiles. Later, Microsoft introduced a new version of PowerShell as pwsh.exe. The set windows-powershell setting can't be changed to use pwsh.exe, because the two version are incompatible, and some justfiles using set windows-powershell might break. So, it is now proposed that we adde a new setting set windows-shell := […] that allows setting an arbitrary shell for Windows. This allows users to opt-in to whatever shell they like on Windows, and is probably what we should have done from the beginning. I'm pretty sure this is a good change, but I don't use Windows, so I'm always nervous about things like this. Comment and let me know what you think! See the PR here #1198 and the issue with comments here #1190.

@casey casey changed the title Feedback Solicitation Thread: Subscribe to get feedback requests! Subscribe to this issue to get requests for user feedback! May 29, 2022
@casey
Copy link
Owner Author

casey commented Nov 16, 2022

Third request: A proposal for a new recipe type, which solves a number of issues and inconsistencies, and could be made the default recipe type in a future edition.

@casey
Copy link
Owner Author

casey commented Dec 29, 2023

Fourth request! Just now has modules and imports.

Imports load a source file and include all items in the source file in the current justfile.

If a justfile contains:

import 'foo.just'

And foo.just contains:

foo:
  @echo FOO

Then running just foo will print FOO.

Modules create independent submodules, whose recipes can be invoked as subcommands:

If a justfile contains:

mod foo

And foo.just contains:

bar:
  @echo BAR

Then running just foo bar will print BAR.

Imports are stable, but modules are currently unstable, so you'll need the --unstable flag to use them.

Modules are a big feature, so I'm hoping to get plenty of testing and feedback before stabilizing them. Try them out and let me know what you think! You can see planned features and leave feedback in #929.

@casey
Copy link
Owner Author

casey commented May 25, 2024

I want to give a final call for testing and feedback for the modules feature. All bugs I know of have been fixed, and I added a source_file() and source_directory() for getting the file of the current source file, and the directory that contains it, respectively.

I think it's pretty much ready to go, and I'll try to stabilize them in a month, assuming nothing goes wrong. Check out the tracking issue to leave your comments!

Also, while I have your attention, we just released 1.27.0, which has a ton of new features and functions, so check that out too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant