clarify the matching pat in replacement documentation

[nyurik]

String manipulation contains this section which is not very clear. Does pat refer to an exact string match, e.g. removing trim_end_match("foobar", "bar") would result in "foo", or does it support some pattern matching (as the variable name would imply)? I tried it with regex, but it seems like it is not working.

trim_end_match(s, pat) - Remove suffix of s matching pat.
trim_end_matches(s, pat) - Repeatedly remove suffixes of s matching pat.
trim_start_match(s, pat) - Remove prefix of s matching pat.
trim_start_matches(s, pat) - Repeatedly remove prefixes of s matching pat.

[laniakea64]

It's an exact string match. These functions call Rust functions for these jobs, passing them the pat parameter string as-is:

just/src/function.rs

Lines 429 to 435 in d3d0dbe

	fn trim_end_match(_context: &FunctionContext, s: &str, pat: &str) -> Result<String, String> {
	Ok(s.strip_suffix(pat).unwrap_or(s).to_owned())
	}
	fn trim_end_matches(_context: &FunctionContext, s: &str, pat: &str) -> Result<String, String> {
	Ok(s.trim_end_matches(pat).to_owned())
	}

just/src/function.rs

Lines 441 to 447 in d3d0dbe

	fn trim_start_match(_context: &FunctionContext, s: &str, pat: &str) -> Result<String, String> {
	Ok(s.strip_prefix(pat).unwrap_or(s).to_owned())
	}
	fn trim_start_matches(_context: &FunctionContext, s: &str, pat: &str) -> Result<String, String> {
	Ok(s.trim_start_matches(pat).to_owned())
	}