Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Auto-Version #389

Open
nickajacks1 opened this issue Sep 21, 2023 · 6 comments
Open

Validate Auto-Version #389

nickajacks1 opened this issue Sep 21, 2023 · 6 comments

Comments

@nickajacks1
Copy link
Contributor

Auto-Version does not validate that newly added versions can be installed and validated.
See: #388

It might be nice if the auto-version github workflow could catch errors like this, for example by attempting to install any auto-versioned packages.

@alecthomas
Copy link
Collaborator

This is deliberate, but unfortunate. We used to do this, but it results in a large number of requests and we would get rate limited.

We could potentially add an auto-version --limit flag, so that at most N packages would be updated on each run.

@nickajacks1
Copy link
Contributor Author

Could the rate limit be worked around by instead creating PRs that get auto merged when the checks pass?
A PR may also make it easier to fix any problems.

@alecthomas
Copy link
Collaborator

The rate limiting was caused by the package downloads, I'm not sure how additional PRs would help?

@nickajacks1
Copy link
Contributor Author

Apologies for the novice question, but I figured I'd just ask to be safe: if I play around with the workflows on my own fork to better understand the issue (replacing the github token with my own), that wouldn't affect this repository in any way would it?

@alecthomas
Copy link
Collaborator

No, not at all.

@nickajacks1
Copy link
Contributor Author

nickajacks1 commented Sep 25, 2023

When you say rate limit, do you mean GitHub API rate limit, or is there some other limit? hermit install doesn't make any API calls does it?

I'm not sure how additional PRs would help?

I had assumed that the package sanity check included a hermit install check, which I see now that it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants