Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exemplar root index.ts pull tab name from miskTab file #581

Open
adrw opened this issue Sep 12, 2019 · 0 comments
Open

Make exemplar root index.ts pull tab name from miskTab file #581

adrw opened this issue Sep 12, 2019 · 0 comments
Labels
@misk/core palette Palette Example Tab

Comments

@adrw
Copy link
Collaborator

adrw commented Sep 12, 2019

Currently

import { createApp, createIndex } from "@misk/core"
import * as Ducks from "./ducks"
import routes from "./routes"

export * from "./components"
export * from "./containers"

createIndex("home", createApp(routes), Ducks)

Want to get rid of manual setting of "home" which is prone to being forgotten if tab is renamed.

import { createApp, createIndex } from "@misk/core"
import miskTab from "../miskTab"
import * as Ducks from "./ducks"
import routes from "./routes"

export * from "./components"
export * from "./containers"

createIndex(miskTab.slug, createApp(routes), Ducks)

Challenges

  • Difficult / impossible to read a file from outside of src/ in past experience
@adrw adrw added @misk/core palette Palette Example Tab labels Sep 12, 2019
@adrw adrw changed the title Make Palette index.ts pull tab name from miskTab file Make exemplar root index.ts pull tab name from miskTab file Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@misk/core palette Palette Example Tab
Projects
None yet
Development

No branches or pull requests

1 participant