Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish snapshots to Github Packages #1491

Closed
wants to merge 1 commit into from
Closed

Publish snapshots to Github Packages #1491

wants to merge 1 commit into from

Conversation

JGulbronson
Copy link
Collaborator

Fixes #1489

I tested this on my fork and it worked like a charm. I did end up using the maven-publish plugin which was easier to get working, I wasn't sure on the benefit of the existing plugin. Happy to discuss that though.

This should publish snapshots to Github Packages on pushes to master (merging PR's counts), and it'll only run on the cashapp/misk project, not any forks.

If this is merged, I'll update the broken link in the README in a followup.

@JGulbronson
Copy link
Collaborator Author

You can see the Action run here from my PR to my fork: https://github.com/JGulbronson/misk/runs/636722897

@shellderp shellderp requested a review from swankjesse May 1, 2020 15:55
@shellderp
Copy link
Collaborator

snapshots is great! pretty sure this is missing miskweb resources though

@JGulbronson
Copy link
Collaborator Author

Good point, perhaps that's what uploadArchive was doing, I'm sure @swankjesse will know. Seems that test is flakey, cause I didn't touch any code.

@shellderp shellderp requested review from shellderp and removed request for shellderp May 14, 2020 21:25
shellderp
shellderp requested changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@shellderp shellderp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix miskweb

@adrw
Copy link
Collaborator

adrw commented Jun 16, 2020

You'll want something like this for Misk-Web

- name: install misk-web
  run: npm install -g @misk/cli
- name: build tabs
  run: miskweb ci-build -e

@chris-ryan-square
Copy link
Contributor

If this PR is still relevant, then please rebase and get a green CI build.
If the PR is no longer relevant please close.

This PR will be closed at the end of January 2021 otherwise.

@adrw
Copy link
Collaborator

adrw commented Jan 13, 2021

Snapshot releases now work published to Sonatype AFAIK so we probably can close this https://github.com/cashapp/misk/actions?query=workflow%3A%22Publish+a+release%22

@chris-ryan-square
Copy link
Contributor

Closing as suggested.

@shellderp
Copy link
Collaborator

Snapshot releases now work published to Sonatype AFAIK so we probably can close this https://github.com/cashapp/misk/actions?query=workflow%3A%22Publish+a+release%22

I think it's broken with a credential problem.. but should work in theory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellderp shellderp shellderp requested changes

@swankjesse swankjesse Awaiting requested review from swankjesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snapshot builds are (not) available.
4 participants
@JGulbronson @shellderp @adrw @chris-ryan-square