-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQLDelight support #1524
Comments
High level it'd be good to know if there's more blockers to getting this in misk. We've worked on compatibility with faire's setup and it looks good to go. Schemas can be built from flyway-compatible migration files instead of needing to redeclare anything which I think was the biggest blocker. The only dependency we need from misk is a |
Actually there is one potential issue, I think Misk currently doesn't support non .SQL extensions for migrations. And I think it might have some issues but having them in resources, but I could be wrong on that. |
that should still be fine, the sqldelight task can output |
We've talked about decoupling the jdbc and hibernate stuff internally before to support sqlc and sqldelight. I think people are interested but no one has done the work yet. +1 on separating |
+1 to extracting JDBC related things One other point: the |
I think the JDBC module should be an implementation detail of actual consumer modules. Really people should only be using something higher level like misk-hibernate which would still have |
I started working on extracting the pure JDBC parts from Hibernate to separate it into a |
@JGulbronson I'd be happy to review and merge any such PRs though. But start off splitting up the |
|
@AlecStrong and I have been adding MySQL support to SQLDelight over the past week, and I think it's just about at the point there's enough functionality to look at getting it in to Misk.
The way I'm picturing this would be to pull the JDBC stuff out in to it's own module, (
misk-jdbc
?). This would make support config likemisk-hibernate
does today, and provide aDataSourceService
which SQLDelight could use for connections.Wanted to open this issue to see if
a) there's interest in getting this merged. @swankjesse feels like you're the person to ask
b) if there is interest, talk next steps for implementing, so there's no surprises in a future PR
The text was updated successfully, but these errors were encountered: