Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move multiplatform target configuration into redwoodBuild DSL #1665

Open
JakeWharton opened this issue Nov 2, 2023 · 2 comments
Open

Move multiplatform target configuration into redwoodBuild DSL #1665

JakeWharton opened this issue Nov 2, 2023 · 2 comments

Comments

@JakeWharton
Copy link
Member

We still have a few projects that define the targets manually because they only need a subset. We should normalize these by the role of the project.

Currently we run all JS tests in the browser despite only a single module needing browser-based testing. We should default to NodeJS testing and allow overriding to use the browser only where needed. Don't think this is by role, but is perhaps a modifier on a role.

Maybe

fun kotlinMultiplatform(role: Role, vararg modifiers: RoleModifier)

enum class Role { RedwoodLibrary, TreehouseHostLibrary, TreehouseGuestLibrary, SampleApp, ... }
enum class RoleModifier { JsBrowserTests, ... }
@JakeWharton
Copy link
Member Author

Actually we can probably infer kotlin-multiplatform from the role so perhaps it's just a single function or var.

@JakeWharton
Copy link
Member Author

Gotta do this so I can link it from a blog post slamming convention plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant