Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better row insert/remove/move animations in LazyColumn #1840

Open
swankjesse opened this issue Mar 4, 2024 · 1 comment
Open

Better row insert/remove/move animations in LazyColumn #1840

swankjesse opened this issue Mar 4, 2024 · 1 comment

Comments

@swankjesse
Copy link
Collaborator

Right now we tell UITableView / RecyclerView that rows have been added or removed, but we don’t expose APIs to express which animations to use.
@josereyes
Copy link

I believe we need to replace UIViewLazyList.kt's insertRows(...) and deleteRows(...) UITableViewRowAnimationNone with UITableViewRowAnimationAutomatic

This video shows the expected behavior https://youtu.be/-joSiASAnjA?t=184

dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
[WIP][DNM] Batching insert/deleteRows calls in LazyListUpdateProcessor
86fe1be 
This is an attempt to resolve issue #1840
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
Adding begin/endUpdates calls to insert/deleteRows hooks in UIViewLaz…
3de409d 
…yList

As per [Apple's docs](https://developer.apple.com/documentation/uikit/uitableview/1614908-beginupdates), this allows the insertion/deletion animations to occur simultaneously across multiple rows.

This is "step 0" of addressing issue #1840.
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
Adding begin/endUpdates calls to insert/deleteRows hooks in UIViewLaz…
db03400 
…yList

As per [Apple's docs](https://developer.apple.com/documentation/uikit/uitableview/1614908-beginupdates), this allows the insertion/deletion animations to occur simultaneously across multiple rows.

This is "step 0" of addressing issue #1840.
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
[WIP][DNM] Batching insert/deleteRows calls in LazyListUpdateProcessor
fd3757a 
This is an attempt to resolve issue #1840
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
Adding begin/endUpdates calls to insert/deleteRows hooks in UIViewLaz…
71157e8 
…yList

As per [Apple's docs](https://developer.apple.com/documentation/uikit/uitableview/1614908-beginupdates), this allows the insertion/deletion animations to occur simultaneously across multiple rows.

This is "step 0" of addressing issue #1840.
@dnagler dnagler mentioned this issue Mar 12, 2024
Merged
1 task
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
Adding begin/endUpdates calls to insert/deleteRows hooks in UIViewLaz…
1512743 
…yList (#1866)

As per [Apple's docs](https://developer.apple.com/documentation/uikit/uitableview/1614908-beginupdates), this allows the insertion/deletion animations to occur simultaneously across multiple rows.

This is "step 0" of addressing issue #1840.
dnagler added a commit that referenced this issue Mar 12, 2024
@dnagler
[WIP][DNM] Batching insert/deleteRows calls in LazyListUpdateProcessor
5cbfcc8 
This is an attempt to resolve issue #1840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swankjesse @josereyes