Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeListener should not get TreehouseView parameter #1857

Open
JakeWharton opened this issue Mar 11, 2024 · 1 comment
Open

CodeListener should not get TreehouseView parameter #1857

JakeWharton opened this issue Mar 11, 2024 · 1 comment

Comments

@JakeWharton
Copy link
Member

There is no way to guarantee the TreehouseView subtype nor the type parameter type that is in use. Instead, the listener should capture the direct TreehouseView subtype instance directly. Through this it does not need a subtype cast, does not need to a type parameter cast, and will actually work with UI systems that do not support arbitrary external mutation (i.e., Compose UI and Swift UI).

@JakeWharton
Copy link
Member Author

Note: This requires some work in our internal usage before it can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant