Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize LazyList by using scroll direction to influence the loaded window #2002

Open
swankjesse opened this issue May 1, 2024 · 2 comments
Open

Optimize LazyList by using scroll direction to influence the loaded window #2002

swankjesse opened this issue May 1, 2024 · 2 comments
Labels
enhancement redwood/lazylayout Relating to `LazyColumn` or `LazyRow`

Comments

@swankjesse
Copy link
Collaborator

We currently load 15 items above and below the visible window. This is a simple strategy that mostly works, but there’s opportunities to make it more efficient:

  • Don't load items above when we're fling-scrolling down
  • Load already-requested items (the loaded window) in the current composition, then load next-requested items in the next composition.
@JakeWharton JakeWharton added enhancement redwood/lazylayout Relating to `LazyColumn` or `LazyRow` labels May 1, 2024
dnagler added a commit that referenced this issue May 1, 2024
@dnagler
In UIViewLazyList, change the itemsBefore and itemsAfter counts depen…
6160be8 
…ding on scroll direction

This is a partial implementation for #2002
dnagler added a commit that referenced this issue May 1, 2024
@dnagler
In UIViewLazyList, change the itemsBefore and itemsAfter counts depen…
ef679f1 
…ding on scroll direction

This is a partial implementation for #2002
dnagler added a commit that referenced this issue May 1, 2024
@dnagler
In UIViewLazyList, change the itemsBefore and itemsAfter counts depen…
7377035 
…ding on scroll direction

This is a partial implementation for #2002
dnagler added a commit that referenced this issue May 1, 2024
@dnagler
In UIViewLazyList, change the itemsBefore and itemsAfter counts depen…
2410c17 
…ding on scroll direction

This is a partial implementation for #2002
dnagler added a commit that referenced this issue May 1, 2024
@dnagler
In UIViewLazyList, change the itemsBefore and itemsAfter counts depen…
553e457 
…ding on scroll direction

This is a partial implementation for #2002
dnagler pushed a commit that referenced this issue May 7, 2024
@swankjesse @dnagler
Change LazyListState to be scroll-aware
16579e3 
- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002
dnagler pushed a commit that referenced this issue May 7, 2024
@swankjesse @dnagler
Change LazyListState to be scroll-aware
ff3ef3d 
- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002
dnagler pushed a commit that referenced this issue May 7, 2024
@swankjesse @dnagler
Change LazyListState to be scroll-aware
4f865ca 
- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002
@dnagler dnagler mentioned this issue May 7, 2024
Merged
1 task
dnagler pushed a commit that referenced this issue May 7, 2024
@swankjesse @dnagler
Change LazyListState to be scroll-aware
8afe071 
- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002
dnagler pushed a commit that referenced this issue May 7, 2024
@swankjesse @dnagler
Change LazyListState to be scroll-aware
13f5f06 
- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002
dnagler added a commit that referenced this issue May 8, 2024
@dnagler @swankjesse
Change LazyListState to be scroll-aware (#2013)
e918243 
* Change LazyListState to be scroll-aware

- Reduce the size of the preload window while actively scrolling
- Once scrolling is completed, optimize the preload window so that, for example, if the user is scrolling down, we load more items below than above

This addresses issue #2002

* Track scrolled content changes

---------

Co-authored-by: Jesse Wilson <jwilson@squareup.com>
@dnagler dnagler closed this as completed May 8, 2024
@dnagler
Copy link
Collaborator

dnagler commented May 8, 2024

Fixed in #2013!

@dnagler dnagler reopened this May 14, 2024
@dnagler
Copy link
Collaborator

dnagler commented May 14, 2024

#2013 2013 was reverted in #2022--turns out the TODO we left should've been tackled in the same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement redwood/lazylayout Relating to `LazyColumn` or `LazyRow`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JakeWharton @swankjesse @dnagler