Review conditional compilation symbols

[Jevonius]

The move from netstandard1.6 to netstandard2.0 has made some of the conditional compilation symbols obsolete. Using this issue as a place to track reviewing them. Depending on what fixes are needed, it might be that previously unavailable functionality can just be enabled for netstandard2.0/net6.0, or alternatively the functionality could be pulled out into extension nuget packages and left as optional (if enabling the functionality involves additional nuget packages for example).

Code

• CASTLE_SERVICES_LOGGING (Remove, Remove obsolete code in Castle.Facilities.Logging #636)
• FEATURE_APPDOMAIN
• FEATURE_ASSEMBLIES
• FEATURE_EVENTLOG (Remove, Remove obsolete code in Castle.Facilities.Logging #636)
• FEATURE_GAC (Remove, Swap FEATURE_GAC for built-in NET462_OR_GREATER #643)
• FEATURE_GETCALLINGASSEMBLY (Remove) #632
• FEATURE_ISUPPORTINITIALIZE (Remove) #633
• FEATURE_PERFCOUNTERS
• FEATURE_REMOTING
• FEATURE_SECURITY_PERMISSIONS
• FEATURE_SERIALIZATION
• FEATURE_SYSTEM_CONFIGURATION
• FEATURE_URIMEMBERS (Remove) #634

Tests

• FEATURE_CODEDOM
• FEATURE_CONSOLETRACELISTENER (Leave); netstandard/net6 will require configuration to be manually applied rather than auto-loaded.
• FEATURE_THREADABORT
• FEATURE_WPF
• NUNIT_SETCULTUREATTRIBUTE (NUNIT_SETCULTUREATTRIBUTE and NUNIT_TIMEOUTATTRIBUTE (Remove) #635)
• NUNIT_TIMEOUTATTRIBUTE (NUNIT_SETCULTUREATTRIBUTE and NUNIT_TIMEOUTATTRIBUTE (Remove) #635)

(List taken from the README, there might be others in use, or some might have already been retired)

[Jevonius]

A few of these could be removed by using built-in symbols (such as NETFRAMEWORK) instead of defining custom symbols (FEATURE_CODEDOM and FEATURE_THREADABORT, potentially others).

Is there a preference one way or the other? Personal preference would be to use built-in where possible.

[jonorossi]

Originally I put all these symbols in when we first started with DNX (to become .NET Core 1.0), back then the API surface was very small and constantly changing while in preview. If we can get rid of heaps of these either through not needing them any more or removing the feature, happy for you to use in-built symbols which didn't exist in the original tooling.