Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same objects don't seem to stack #4470

Open
Unrepentant-Atheist opened this issue Apr 12, 2024 · 7 comments
Open

Same objects don't seem to stack #4470

Unrepentant-Atheist opened this issue Apr 12, 2024 · 7 comments

Comments

@Unrepentant-Atheist
Copy link

Unrepentant-Atheist commented Apr 12, 2024

Describe the bug

According to devs in discord "samey" object should stack. They do not...always.

image

Comparing 2 non-stackable items:

image
image

Steps To Reproduce

  1. Loot stuff
  2. Be angry at 10000000000000000 items in the list
  3. ???
  4. Don't profit

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4291 (22H2)
  • Game Version: a4f8689 [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: English [en_US]
  • Mods loaded: [
    Bright Nights [bn],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Bionic Slots [cbm_slots],
    Elevated bridges [elevated_bridges],
    Teleportation [teleportation_tech],
    Cataclysm++ [Cata++],
    Aftershock [aftershock],
    PKs Rebalancing [PK_REBALANCE],
    Secronom [secronom],
    Secronom+ Lore Expansion [secronom_lore_expansion],
    C.R.I.T. Expansion [crt_expansion],
    Sierra Madre [sierra_madre],
    Bio-Synth Robot expansion [gekkobots],
    Nechronica Redux [Nechronica_Redux],
    Really Dark Skies [realdarkskies],
    Arcana and Magic Items [Arcana],
    Magical Nights [MagicalNights],
    Project: Pack Rat [Jake's_Squirrel_mod],
    Add Bandits Extended+ [GOV_BANDITS_KAI_R],
    NPC Increased Location Spawns Combined [npc_increased_location_comb],
    More Bandits, Testing version [More_Bandits],
    More Dangerous Encounters [More_Dangerous_Encounters],
    Morlock Village [morlock_village]
    ]

Additional context

No response

@scarf005
Copy link
Member

scarf005 commented Apr 12, 2024

due to how item containers work, items inside plastic bags, paper wrappers, liquid container (e.g can) already has charges and thus cannot be stacked.

e.g

  • pizza (5) + pizza (5) = pizza (10)
  • chips (plastic bag) (5/100) + chips (plastic bag) (5/100) = ????

there's no default behavior everyone can agree on yet. some will be unsatisfied that it's not chips (plastic bag) (10/100) and some will feel the opposite, thus the items inside containers aren't merging.
this could be made configurable in the future, however.

@scarf005 scarf005 removed the bug label Apr 12, 2024
@scarf005 scarf005 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@scarf005
Copy link
Member

on other thoughts why let's make it configurable.

@scarf005 scarf005 reopened this Apr 13, 2024
@Ignaramico
Copy link

im noticing that some items kinda stack (the number before the weight value) but other are separate even though they have the same charges; its because of the freshness stuff?

@chaosvolt
Copy link
Member

One thing that has me curious, cash cards stack just fine. They're like one of the few items to do so flawlessly, I think. Whatallows them to?

@scarf005
Copy link
Member

im noticing that some items kinda stack (the number before the weight value) but other are separate even though they have the same charges; its because of the freshness stuff?

could you elaborate with example? i'm not sure what the number before weight value means

@slysnek
Copy link

slysnek commented Apr 15, 2024

im noticing that some items kinda stack (the number before the weight value) but other are separate even though they have the same charges; its because of the freshness stuff?

could you elaborate with example? i'm not sure what the number before weight value means

He probably means 'amt' column in advanced inventory
image

What I can relate to concerning this bug is that some food items, which has infinite storage value do not seem to stack, like nuts or powdered eggs for example.

image

They do have absolutely similar stats, however, and if we talk about powdered eggs, they were made of chicken eggs with same attributes. Maybe the freshness of the eggs are taken into consideration when they are being turned to powdered ones?

@VissValdyr
Copy link
Contributor

im noticing that some items kinda stack (the number before the weight value) but other are separate even though they have the same charges; its because of the freshness stuff?

could you elaborate with example? i'm not sure what the number before weight value means

He probably means 'amt' column in advanced inventory image

What I can relate to concerning this bug is that some food items, which has infinite storage value do not seem to stack, like nuts or powdered eggs for example.

image

They do have absolutely similar stats, however, and if we talk about powdered eggs, they were made of chicken eggs with same attributes. Maybe the freshness of the eggs are taken into consideration when they are being turned to powdered ones?

If you still have the save, we have the feature of merging samey freshness objects into one stack, if you set it super high and pick the powdered eggs up, are they merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants