From cca59235023fa30339086be845d9cd7214ecff91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Tue, 31 May 2022 23:57:02 +0200 Subject: [PATCH] Leak full Wparentheses suppression for GCC 9 Reported as an issue on Discord. I thought that by GCC 9, the C++ frontend was fixed enough to support `_Pragma`-based suppression correctly, but apparently I was wrong. --- src/catch2/internal/catch_test_macro_impl.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/catch2/internal/catch_test_macro_impl.hpp b/src/catch2/internal/catch_test_macro_impl.hpp index 7181204059..95384bc155 100644 --- a/src/catch2/internal/catch_test_macro_impl.hpp +++ b/src/catch2/internal/catch_test_macro_impl.hpp @@ -14,9 +14,9 @@ #include #include -// We need this suppression to leak, because it took until GCC 9 +// We need this suppression to leak, because it took until GCC 10 // for the front end to handle local suppression via _Pragma properly -#if defined(__GNUC__) && !defined(__clang__) && !defined(__ICC) && __GNUC__ < 9 +#if defined(__GNUC__) && !defined(__clang__) && !defined(__ICC) && __GNUC__ <= 9 #pragma GCC diagnostic ignored "-Wparentheses" #endif