From ff9506cedd423a72a6b9ff1f827aae74c8166117 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Ho=C5=99e=C5=88ovsk=C3=BD?= Date: Sun, 5 Jun 2022 14:51:34 +0200 Subject: [PATCH] Only test SEH handling with MSVC MinGW doesn't support `__try` and friends at all, while Clang only supports it partially, and the test would require some changes to make it work there. Since this is only a test, we can afford to keep it MSVC-only. Closes #2447 --- tests/SelfTest/UsageTests/Misc.tests.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/SelfTest/UsageTests/Misc.tests.cpp b/tests/SelfTest/UsageTests/Misc.tests.cpp index 2e4badf5ce..93b5ff1ec5 100644 --- a/tests/SelfTest/UsageTests/Misc.tests.cpp +++ b/tests/SelfTest/UsageTests/Misc.tests.cpp @@ -508,7 +508,8 @@ TEMPLATE_TEST_CASE_SIG("#1954 - 7 arg template test case sig compiles", "[regres TEST_CASE("Same test name but with different tags is fine", "[.approvals][some-tag]") {} TEST_CASE("Same test name but with different tags is fine", "[.approvals][other-tag]") {} -#if defined(CATCH_PLATFORM_WINDOWS) +// MinGW doesn't support __try, and Clang has only very partial support +#if defined(_MSC_VER) void throw_and_catch() { __try { @@ -549,4 +550,4 @@ TEST_CASE("Validate SEH behavior - no crash for stack unwinding", "[approvals][! throw 1; } -#endif // CATCH_PLATFORM_WINDOWS +#endif // _MSC_VER