Infinite recursion in Generators::populate with MSVC

[C4rsten]

CATCH_TEST_CASE("Recursion Bug")
{
    int x = 42;
    auto test = GENERATE_COPY(1, x, 2 * x);
    CATCH_CHECK(test < 50);
}

This worked in 2.9.2 but now I get
single_include\catch2\catch.hpp(4027):warning C4717: 'Catch::Generators::Generators<int>::populate<int &>': recursive on all control paths, function will cause runtime stack overflow with MSVC 2017 Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27042 for x64.
It matches the wrong template.

A possible work-around is GENERATE_COPY(values<int>({1, x, 2 * x}));, but the above should work, right?

[horenmar]

I can reproduce this with an up-to-date MSVC.

However, it doesn't reproduce with Clang/GCC, so I suspect the code runs into some MSVC bug, which is going to be hard to debug.

[horenmar]

Does not reproduce with /permissive-...

[horenmar]

So, this was almost definitely introduced in 6c9a255.