Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The output of --list-* flags obeys -o flag #2163

Merged
merged 5 commits into from Jan 27, 2021

Conversation

horenmar
Copy link
Member

Description

This PR changes behaviour of --list-* flags so that if output target is provided via -o flag, the resulting listing is written to that target, rather than to stdout, like it was in v2.

There is also a bunch of internal changes and refactorings to enable this feature, and to make future implementation of multiple reporters simpler.

GitHub Issues

#2061

Previously, every base derived from the IStreamingReporter had
its own `IConfig const* m_config` member, so this just centralizes
the handling thereof.

Part of #2061
The previous commit made it so that the `IConfig` is stored in
`IStreamingReporter` and thus always available.
Also generalized the implementations to write to the provided
output stream, which will be required for the follow up changes,
where the listings should happen to the location user asked for
by specifying the `-o` flag.
Also added tests for the default implementations of list* reporter
helpers.

Closes #2061
@horenmar horenmar self-assigned this Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #2163 (971b1fc) into devel (ba81505) will increase coverage by 0.04%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##            devel    #2163      +/-   ##
==========================================
+ Coverage   90.03%   90.07%   +0.04%     
==========================================
  Files         146      146              
  Lines        7089     7110      +21     
==========================================
+ Hits         6382     6404      +22     
+ Misses        707      706       -1     

@horenmar horenmar merged commit b435e39 into devel Jan 27, 2021
@horenmar horenmar deleted the devel-list-outputs-to-out-flag branch January 28, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant