Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllTrue, AnyTrue, NoneTrue generic range matchers #2319

Merged
merged 3 commits into from Jul 16, 2022

Conversation

schallerr
Copy link
Contributor

Description

This PR adds AllTrue, AnyTrue, NoneTrue generic range matchers, which match a range if all, any, or none of the elements in a range are true, respectively.

GitHub Issues

Addresses issue #2109.

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #2319 (1b9fc4b) into devel (a6d59b6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1b9fc4b differs from pull request most recent head cf4793c. Consider uploading reports for the commit cf4793c to get more accurate results

@@            Coverage Diff             @@
##            devel    #2319      +/-   ##
==========================================
+ Coverage   91.49%   91.52%   +0.03%     
==========================================
  Files         181      182       +1     
  Lines        7519     7549      +30     
==========================================
+ Hits         6879     6909      +30     
  Misses        640      640              

@Garz4
Copy link
Contributor

Garz4 commented Dec 25, 2021

Closes #2136.

@johnbeard
Copy link
Contributor

If I could rebase this and include the (All|Any|None)True matchers in the now-existing src/catch2/matchers/catch_matchers_quantifiers.hpp(since 57c8036), would that work? Or should they be implemented differently?

@johnbeard
Copy link
Contributor

johnbeard commented Feb 19, 2022

Actually, clearly I misread the diff - the only rebase needed here was in .gitignore and the approval test counts: https://github.com/johnbeard/Catch2/tree/matchers_all_any_none_true

Is there anything else I can do here to drive this forward? Merging these matchers would be useful to me.

@horenmar
Copy link
Member

horenmar commented Mar 5, 2022

@johnbeard If you split out the test refactoring to separate PR and then a separate PR for the new functionality, I will review both.

@schallerr
Copy link
Contributor Author

I split out the test refactoring to #2386. I'll rebase this PR once the other one is merged.

@horenmar horenmar merged commit 1bd2338 into catchorg:devel Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants