Suppress -Wuseless-cast Warning #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed that there is a .clang-format, but at least the from me touched code isn't clang-formated at all. Should that stay, or should I at least format the code I've added/changed? |
Codecov Report
@@ Coverage Diff @@
## devel #2521 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 183 183
Lines 7562 7562
=======================================
Hits 6922 6922
Misses 640 640 |
|
clang-format was added later in development, and it doesn't have the right options to faithfully replicate the desired formatting. The general policy is to use it on newly added/changed code, unless it messes up the overall formatting too much (and at some point figure out a way to deal with this 😃 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suppresses a warning, because we hit the warning in our test code (with -Werror).
GitHub Issues
Closes #2520.