Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose header windows.h in catch_all.hpp #2526

Merged
merged 2 commits into from Oct 3, 2022

Conversation

dimztimz
Copy link
Contributor

Fixes #2432.

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #2526 (e889084) into devel (98d37da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2526   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         183      183           
  Lines        7560     7560           
=======================================
  Hits         6922     6922           
  Misses        638      638           

@dimztimz
Copy link
Contributor Author

Any comments on this?

@horenmar
Copy link
Member

horenmar commented Oct 3, 2022

Eeeeeeeh, sure.

@horenmar horenmar merged commit 980c206 into catchorg:devel Oct 3, 2022
@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows_h_proxy is included in catch_all.hpp and does name-polution
2 participants