meson cleanups with muon #2539
Merged
meson cleanups with muon #2539
+144
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
reviewed
Oct 3, 2022
Codecov Report
@@ Coverage Diff @@
## devel #2539 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 183 183
Lines 7558 7558
=======================================
Hits 6920 6920
Misses 638 638 |
Cleans it up. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Allows muon to alphabetically sort files. switch headers back to arrays as split() can only be used on strings. Signed-off-by: Rosen Penev <rosenp@gmail.com>
horenmar
reviewed
Oct 3, 2022
| 'catch_tostring.cpp', | ||
| 'catch_totals.cpp', | ||
| 'catch_version.cpp', | ||
| ) | ||
|
|
||
| reporter_headers = [ |
There was a problem hiding this comment.
Why are some changed to files and some are not?
--e--
Actually I see it is a headers vs sources split, but same question.
There was a problem hiding this comment.
I mentioned it in the commit message. split() is used later on. That only works for strings, not files.
horenmar
added
the
Building and Packaging
|
OK, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
muon: https://sr.ht/~lattis/muon/ has a formatter that can be used to clean up meson build files. Similar to clang-format.