Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScopedMessage in INFO logging macro const #2564

Conversation

Rjblaauboer
Copy link
Contributor

@Rjblaauboer Rjblaauboer commented Nov 10, 2022

Description

What: Made Catch::ScopedMessage in the INFO logging macro const because it is not modified.

Why: If users have const correctness checks enabled then the current non-const message would be flagged forcing users to wrap the INFO macro themselves or forego using it altogether.

We encountered this while using clang-tidy with the misc-const-correctness check.

GitHub Issues

If users have const correctness checks enabled then this would flagged forcing users to wrap the INFO macro themselves or forego using it altogether.
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #2564 (2449166) into devel (066cc51) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2564      +/-   ##
==========================================
- Coverage   91.09%   91.09%   -0.00%     
==========================================
  Files         187      187              
  Lines        7623     7622       -1     
==========================================
- Hits         6944     6943       -1     
  Misses        679      679              

@horenmar
Copy link
Member

Sure, thanks.

@horenmar horenmar merged commit b65c0e2 into catchorg:devel Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants