Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating point matchers for std::complex<T> #2701

Open
quantumsteve opened this issue Jun 8, 2023 · 0 comments
Open

floating point matchers for std::complex<T> #2701

quantumsteve opened this issue Jun 8, 2023 · 0 comments

Comments

@quantumsteve
Copy link

Description
Describe the feature/change you request and why do you want it.

Our application needs to compare complex numbers for equality. We created a ComplexApprox class to provide this functionality.

std::complex<double> i(0.,1.), j(0.,1.);
CHECK(i == ComplexApprox(j));

We want to make an upstream contribution. Since Approx is deprecated could a custom matcher provide the same functionality? Is such a pull request likely to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant