Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin #1896

Open
sgoudham opened this issue Jan 30, 2023 Discussed in #1827 · 6 comments
Open

Kotlin #1896

sgoudham opened this issue Jan 30, 2023 Discussed in #1827 · 6 comments
Labels
waiting on author Waiting on action from the maintainer

Comments

@sgoudham
Copy link
Contributor

@d1snin has created a Catppuccin Kotlin library.
It's ready for review here - d1snin/catppuccin-kotlin

Discussed in #1827

Originally posted by nullishamy January 15, 2023
Are you available to help in the creation of this port? 馃槃 (optional)
Yes

Additional context 馃摲 (optional)
Kotlin palette lib similar to existing language palettes

@sgoudham sgoudham added port request Port Catppuccin to this app ready for review labels Jan 30, 2023
@sgoudham
Copy link
Contributor Author

Since raising this issue, we've since revamped the palette.json file and now acts as the north star for libraries to implement.

New Catppuccin code libraries should at least have:

  • A Palette object/type/etc that gives users access to the same fields as specified in the palette.json file, which should be generated from the file itself. Examples of this currently include catppuccin/python and catppuccin/rust.
  • Minimal testing, as the code/palette will have been generated.

We'd reconsider the inclusion of this Kotlin library if the above changes are carried out @d1snin

@lighttigerXIV
Copy link
Contributor

Since raising this issue, we've since revamped the palette.json file and now acts as the north star for libraries to implement.

New Catppuccin code libraries should at least have:

  • A Palette object/type/etc that gives users access to the same fields as specified in the palette.json file, which should be generated from the file itself. Examples of this currently include catppuccin/python and catppuccin/rust.
  • Minimal testing, as the code/palette will have been generated.

We'd reconsider the inclusion of this Kotlin library if the above changes are carried out @d1snin

Let me see if i understood correctly. You want the library to be able to read that json? And then the library itself is a parser for that json?

@d1snin
Copy link

d1snin commented Mar 23, 2024

If it's required, I can implement palette.json parsing. But, since the library is minimal in terms of network/IO, it is not planned.

I'll refactor the library to accomplish new standards though

@sgoudham
Copy link
Contributor Author

sgoudham commented Mar 23, 2024

If it's required, I can implement palette.json parsing. But, since the library is minimal in terms of network/IO, it is not planned.

I'll refactor the library to accomplish new standards though

The palette.json can be copied as a local file in the repository, I'd suggest using a GitHub actions workflow similar to the one defined in catppuccin/rust that runs on a schedule to check for updates to the upstream palette.json and raise a pull request if so.

@lighttigerXIV
Copy link
Contributor

that's too much work for me. i will just keep using mine

@d1snin
Copy link

d1snin commented Mar 23, 2024

I'll consider to make palette.json local

@sgoudham sgoudham changed the title Kotlin library Kotlin Mar 23, 2024
@sgoudham sgoudham added waiting on author Waiting on action from the maintainer and removed port request Port Catppuccin to this app labels Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author Waiting on action from the maintainer
Projects
None yet
Development

No branches or pull requests

3 participants