Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome DevTools #2341

Open
1 task done
r58Playz opened this issue Mar 30, 2024 · 3 comments
Open
1 task done

Chrome DevTools #2341

r58Playz opened this issue Mar 30, 2024 · 3 comments

Comments

@r58Playz
Copy link
Member

Link to repository

https://github.com/r58Playz/ctp-devtools.git

Screenshots

Latte

latte

Frappe

frappe

Macchiato

macchiato

Mocha

mocha

Any additional comments?

No response

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@sgoudham
Copy link
Contributor

Hey 👋, sorry for the wait on reviewing this!

A few comments from me:

  1. Please update the outdated icons directory with our latest icon.
  2. As far as I can see, the only files that change from the template directory are devtools.css.hbr and manifest.json.hbr. I believe you should be able to symlink the icons directory, devtools.html, and devtools.js into the themes directory. This will massively reduce the amount of duplicated files and I think users should still be able to download the theme fine.
  3. Since this repository was created, we have since released whiskers v2 which should reduce the complexity in the generate.sh script and the template files, consider updating the repository to use it!

@uncenter I believe you tested this out earlier, did you notice any issues that are worth raising?

@sgoudham sgoudham added the waiting on author Waiting on action from the maintainer label Apr 27, 2024
@uncenter
Copy link
Member

uncenter commented Apr 27, 2024

@uncenter I believe you tested this out earlier, did you notice any issues that are worth raising?

It works great! No issues that I've noticed.

@r58Playz
Copy link
Member Author

Updated according to the suggestions: commit 1f9e119

@sgoudham sgoudham removed the waiting on author Waiting on action from the maintainer label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants