Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gleam #2368

Closed
1 task done
MAHcodes opened this issue Apr 18, 2024 · 7 comments · Fixed by #2399
Closed
1 task done

Gleam #2368

MAHcodes opened this issue Apr 18, 2024 · 7 comments · Fixed by #2399
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer

Comments

@MAHcodes
Copy link
Member

MAHcodes commented Apr 18, 2024

Link to repository

https://github.com/MAHcodes/catppuccin

Screenshots

No response

Any additional comments?

No response

Submission Guidelines

  • I have read and followed Catppuccin's submission guidelines.
@MAHcodes
Copy link
Member Author

I'm writing the build script...

@MAHcodes
Copy link
Member Author

I wrote the build script, and used it to generate the library files under the libdirectory

@sgoudham
Copy link
Contributor

sgoudham commented May 17, 2024

Hey 👋

Thanks for porting the palette to Gleam! A few things:

  1. Please update the code generation to use a pinned version of the palette JSON, this can be done either by copying a version of the palette.json locally into the repository or using a pinned commit hash. FYI: feat: add emoji for each flavor palette#81 has been merged which may or may not break your current builds
  2. Update the LICENSE to be Catppuccin
  3. Please update usages of Flavour to Flavor and Colour to Color (i.e. https://github.com/MAHcodes/catppuccin/blob/51e854643f7ef48862c53c8db50a571f66c7bd0c/src/catppuccin.gleam#L7) as we have chosen to standardise that across the organisation. I understand that this is probably a pain since it's a breaking change, sorry!

Happy to approve after these changes are carried out!

Also can you document / let me know how the repository is published to https://hexdocs.pm/catppuccin/? I don't see a publish script/task or any CI/CD workflows. Is it automatically driven by the gleam.toml?

@sgoudham sgoudham added the waiting on author Waiting on action from the maintainer label May 17, 2024
MAHcodes added a commit to catppuccin/gleam that referenced this issue May 18, 2024
- Update the code generation to use a pinned version of the palette JSON
  by using a pinned commit hash
- Update the LICENSE to be Catppuccin
- update usages of `Flavour` to `Flavor` and `Colour` to `Color`
@MAHcodes
Copy link
Member Author

Hey @sgoudham,

Thanks for the review! I've fixed all the issues. Feel free to suggest any further code improvements.

For now, there's no CI/CD pipeline in place. I'm publishing the library through Gleam CLI.

@sgoudham sgoudham removed the waiting on author Waiting on action from the maintainer label May 18, 2024
@sgoudham
Copy link
Contributor

Great, thanks for pushing out those updates (I believe you need to update the Usage section in the README too!)

It'd be great to get a CI/CD pipeline in place for publishing to Gleam, happy to collaborate further on this! We usually try to publish our packages under a shared organisation account, does Gleam support that concept or is it just 1 library -> 1 author for now? Not a blocker but figured I'd ask anyways.

Happy to approve and get it merged into the organisation, thanks for your work again and apologies for the wait!

You should shortly receive an email inviting you to be apart of the Catppuccin GitHub organisation. Please read, "Transferring a repository owned by your personal account", if you are unsure about the process of transferring the repository to Catppuccin.

We'll close this issue once the port has been added to our ports.yml.

@sgoudham sgoudham added the waiting for transfer Waiting on the repository being transferred from the maintainer label May 18, 2024
@MAHcodes
Copy link
Member Author

Alright, so it seems possible to publish packages with an organiazation on Hex here: https://hex.pm/docs/faq#can-i-publish-public-packages-with-an-organization, I'll need either the organization name you want to use or the author name if you prefer me to transfer ownership here: https://hex.pm/docs/faq#can-i-transfer-ownership-of-a-package.

For CI/CD, I will create a GitHub workflow that will automatically publish the package to Hex.pm whenever a new release is created on GitHub.

@MAHcodes
Copy link
Member Author

I updated the README with the links and implemented CI/CD, which successfully published the latest release to Hex.

@sgoudham sgoudham linked a pull request May 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for transfer Waiting on the repository being transferred from the maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants