Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to nixfmt #127

Closed
getchoo opened this issue Apr 18, 2024 · 1 comment · Fixed by #187
Closed

Move to nixfmt #127

getchoo opened this issue Apr 18, 2024 · 1 comment · Fixed by #187
Assignees
Milestone

Comments

@getchoo
Copy link
Member

getchoo commented Apr 18, 2024

see NixOS/rfcs#166. once there is a stable release, we should probably switch to it in order to conform to the wider community

@getchoo getchoo added the blocked Waiting on external changes label Apr 18, 2024
@getchoo getchoo self-assigned this Apr 18, 2024
@sgoudham
Copy link
Contributor

sgoudham commented Apr 30, 2024

If we care about the formatting of nix code. I'd like it to be automatically carried out by CI, as previously demonstrated in catppuccin/userstyles.

Carrying it out in CI removes the concern from both the maintainer and the contributor. Maintainers don't need to worry about commenting on formatting and contributors will have a smoother experience since the alternative of implementing a nixfmt lint check is frustrating if they don't have a formatter set up already.

@getchoo getchoo added this to the 1.0.0 milestone May 14, 2024
getchoo added a commit to getchoo/ctp-nix that referenced this issue May 21, 2024
follows nixos RFC 166. closes catppuccin#127
getchoo added a commit to getchoo/ctp-nix that referenced this issue May 21, 2024
follows nixos RFC 166. closes catppuccin#127
getchoo added a commit to getchoo/ctp-nix that referenced this issue May 21, 2024
follows nixos RFC 166. closes catppuccin#127
@getchoo getchoo removed the blocked Waiting on external changes label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants