Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document modules that need Allow From Derivation #172

Open
vdbe opened this issue May 14, 2024 · 3 comments
Open

Document modules that need Allow From Derivation #172

vdbe opened this issue May 14, 2024 · 3 comments

Comments

@vdbe
Copy link
Contributor

vdbe commented May 14, 2024

An extra readme segment that specifies which modules require Allow From Derivation
or/and an option to exclude those modules from the global enable option.

@vdbe
Copy link
Contributor Author

vdbe commented May 14, 2024

Willing to implement it myself, just let me know.

@getchoo
Copy link
Member

getchoo commented May 21, 2024

documenting what modules contain it would be nice. feel free to PR it to our FAQ

regarding excluding them from the global enable option: i can see why this might be a requested feature, but i feel would overcomplicate how we actually implement catppuccin.enable for what's a pretty niche feature. giving a neat list of modules should be good enough for most i'd imagine

@vdbe
Copy link
Contributor Author

vdbe commented May 21, 2024

For the option my idea was to have 1 place (2 nixos and home manager) where you use mkOverride with priority over MkOptionDefault.

This way you don't need to touch mkCatppuccinOpt and can possibly generate the description for documentation instead of a Readme/FAQ segment.

Don't know yet how you would test it so that it is not a best effort option.

Would this implementation be overcomplicated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants