Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unthemed Wikipedia elements #670

Open
2 tasks done
enderprism opened this issue Mar 13, 2024 · 4 comments · May be fixed by #963
Open
2 tasks done

Unthemed Wikipedia elements #670

enderprism opened this issue Mar 13, 2024 · 4 comments · May be fixed by #963
Labels
wikipedia Wikipedia

Comments

@enderprism
Copy link

enderprism commented Mar 13, 2024

Is there an existing issue outlining your problem?

  • I am using the latest version of the provided userstyle.
  • I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?

lbl:wikipedia

Describe your problem.

Some elements of Wikiepedia pages aren't themed and stay white, notably banners, which makes them unreadable.

Attach screenshots.

image

What browser(s) are you seeing the problem on?

Firefox v123.0.1

Any additional comments?

No response

@github-actions github-actions bot added the wikipedia Wikipedia label Mar 13, 2024
@kingofcube

This comment was marked as spam.

@GitMuslim
Copy link
Member

@enderprism can you provide the link for the page?

@enderprism
Copy link
Author

@lplawlor
Copy link
Contributor

lplawlor commented Jun 6, 2024

As a follow up, it seems that the box which appears when no article exists at that link is completely different depending on the language.

In English (example), the structure goes:

<div class="noarticletext">
  <div class="mw-parser-output">
    <style>...</style>
    <table id="noarticletext" class="plainlinks fmbox fmbox-system">
      ...

And so the background-color styling is already done by the existing CSS for .mw-parser-output .fmbox.

In French (example), the structure is entirely different, and again for Spanish, German, etc. Moreover, some of the elements within these boxes supply their own style directly within the HTML, so we need to override them with !important.

With all that said, the following seems to fix things on all the languages I've tried, (though I haven't done exhaustive testing):

    .noarticletext, #noarticletext {
      background-color: @base !important;
    }
    
    #sisterproject {
      background-color: @mantle !important; 
    }

English (en.wikipedia.org):
image

French (fr.wikipedia.org):
image

Spanish (es.wikipedia.org):
image

Ukrainian (uk.wikipedia.org):
image

lplawlor added a commit to lplawlor/userstyles that referenced this issue Jun 6, 2024
Fixing issues with background-color on the
`<div class="noarticletext">` tag and tags with
`id=\#sisterproject` in some languages.

Closes catppuccin#670.
Some screenshots are included in my comment on that issue.
@lplawlor lplawlor linked a pull request Jun 6, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wikipedia Wikipedia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants