Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmail: Assumption of a base dark-mode theme #870

Open
2 tasks done
Fenrirthviti opened this issue May 6, 2024 · 0 comments
Open
2 tasks done

gmail: Assumption of a base dark-mode theme #870

Fenrirthviti opened this issue May 6, 2024 · 0 comments
Labels
gmail Gmail

Comments

@Fenrirthviti
Copy link

Fenrirthviti commented May 6, 2024

Is there an existing issue outlining your problem?

  • I am using the latest version of the provided userstyle.
  • I have searched the existing issues and they do not solve my problem.

What userstyles are you seeing the problem on?

lbl:gmail

Describe your problem.

Currently, the gmail theme makes an assumption (requirement?) that a base "dark mode" theme is already selected, which means certain elements will not display properly if the base gmail theme is light. There are specific situations where you cannot apply a dark mode theme to a gmail inbox (such as a delegated inbox, or some enterprise environments) and it would be nice if things worked regardless of the base theme selected. I realize this is annoying as some of the things that do not display properly are images, but I hear tell of dark CSS magic to get them to display properly. Bit of an edge case for sure, but figured I would report as maybe someone a bit more knowledgeable than myself would be able to fix it up quick enough.

Examples below do not cover all instances of this, but if it's helpful, I can try to provide screenshots of things as I come across them. Most are fairly obvious when you have a light mode theme selected. #864 just recently merged fixed a few of these I had noticed and had local patches for, but wanted to raise the larger concern for tracking either way.

Thanks to everyone for all their hard work, and let me know if any additional information is helpful!

Attach screenshots.

Example when a Dark Mode theme is selected as base:
Section titles:
image

Attachment icon:
image

Example when a Light Mode theme is selected as a base:
Section titles:
image

Attachment icon:
image

What browser(s) are you seeing the problem on?

Chrome 124.0.6367.63

Any additional comments?

No response

@github-actions github-actions bot added gmail Gmail stylus Stylus and removed stylus Stylus labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gmail Gmail
Projects
None yet
Development

No branches or pull requests

1 participant