Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine installation files into a single JSON Fragment Extension #17

Open
AdalZanabria opened this issue Nov 26, 2023 · 1 comment · May be fixed by #18
Open

Combine installation files into a single JSON Fragment Extension #17

AdalZanabria opened this issue Nov 26, 2023 · 1 comment · May be fixed by #18

Comments

@AdalZanabria
Copy link
Member

Since version 1.7, Windows Terminal added support for JSON Fragment Extensions

This allows for a user to put a single file into a local config directory that extends the default configuration JSON.

Pros:

This could streamline the installation to only moving a folder instead of copying and pasting from multiple files, also Windows users are more used to drag and droping instead of editing config files.

Cons:

As "Themes" is a relatively new feature to Windows Terminal, it is not yet implemented in JSON Fragment Extensions, their inclusion seem to be coming until version 1.20 (Source).
This could either mean we can only streamline half of the process at the time, or complicate the installation more by introducing a second method.

I'll add a PR to this issue with the schemes as a JSON Fragment Extension and we can leave it cooking until v1.20 releases and I can add the schemes to the fragment too.

In the meantime I'll leave this issue for consideration.

@AdalZanabria
Copy link
Member Author

PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant