BeforeGroups should run before any matched test #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@velma - Please run |
krmahadevan
reviewed
Apr 18, 2022
krmahadevan
reviewed
Apr 18, 2022
testng-core/src/main/java/org/testng/internal/ConfigurationGroupMethods.java
Show resolved
Hide resolved
krmahadevan
reviewed
Apr 18, 2022
testng-core/src/main/java/org/testng/internal/ConfigurationGroupMethods.java
Show resolved
Hide resolved
krmahadevan
approved these changes
Apr 19, 2022
|
@velma - thanks for taking the time to create a sample for the issue and also go the extra mile by helping out with a PR to fix the problem and also sharing the additional context around the review comments. Appreciate your time and effort. Once @juherr takes a look at this PR and approves this PR, we can get this changeset merged into master. We look forward to more such valuable contributions from you |
juherr
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2359
Fixes #2359 .
There is possibility that BeforeGroups method will be run in parallel with test(s) that have this group assigned (see test case), this pull request fixed this situation
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.