Show FQMN for tests in console #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juherr
reviewed
May 11, 2022
|
|
||
| Assert.assertTrue( | ||
| systemOutCapture.toString().contains("PASSED: testMethod(null, \"Bazinga!\")")); | ||
| actual.contains( | ||
| "PASSED: test.reports.ReportTest$NullParameter.testMethod(null, \"Bazinga!\")")); |
There was a problem hiding this comment.
Maybe use another separator symbol between class and method (didn't find if a standard symbol exists)
There was a problem hiding this comment.
@juherr - Is there any issue with using . as the separator here? It seems to be the standard symbol. Even IntelliJ uses that, when you right click a method and say Copy / Paste Special > Copy reference. Wouldn't it confuse users if we ended up introducing something else as the separator ?
juherr
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2741
Fixes #2741 .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.