Refactoring #2821
Merged
Refactoring #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krmahadevan
force-pushed
the
refactoring
branch
from
e5ae7f7
to
d33a610
Compare
krmahadevan
force-pushed
the
refactoring
branch
from
d33a610
to
cecdc2d
Compare
Broke down the implementation into multiple Child classes powered by a factory method.
krmahadevan
force-pushed
the
refactoring
branch
from
cecdc2d
to
ae741c1
Compare
juherr
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
PackageUtilsimplementation into protocol specific implementations.