Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the PSR-4 autoloader #75

Open
peter279k opened this issue Jun 27, 2019 · 2 comments
Open

Consider using the PSR-4 autoloader #75

peter279k opened this issue Jun 27, 2019 · 2 comments

Comments

@peter279k
Copy link

peter279k commented Jun 27, 2019

As title, it seems that this class still uses the classmap approach to load the Browser class in composer.json.

I think we can consider using the PSR-4 autoloader and the advantages are as follows:

  • The PSR-4 approach will have the namespace and it can avoid the class name collision.

Once this issue is accepted, I can help this issue :).

@cbschuld
Copy link
Owner

cbschuld commented Jul 8, 2019

@peter279k - I am completely fine with this; we could issue a 2.x version that has this breaking change for those importing it w/ the classmap model

@peter279k
Copy link
Author

@cbschuld, thanks for your reply and concern.

I think we can mark the 2.x milestone for this issue and it can let us know that it will be the psr-4 compliant autoloader since the package version is 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants