Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose jclouds-core for the Branch API #339

Open
martinda opened this issue May 6, 2022 · 1 comment
Open

Expose jclouds-core for the Branch API #339

martinda opened this issue May 6, 2022 · 1 comment

Comments

@martinda
Copy link
Contributor

martinda commented May 6, 2022

The Branch api exposes com.google.gson.JsonElement, and it comes from jclouds-core transitively:

compileClasspath - ...
+--- org.apache.jclouds:jclouds-core:2.5.0
|    +--- com.google.code.gson:gson:2.8.9

I think the right solution is to declare a direct api dependency on com.google.code.gson:gson:2.8.9 since this library uses an instance of that library via a type declaration in a data type that users are expected to use.

Exposing all of jclouds-core might be excessive, but I have not reviewed the whole list of APIs yet.

This issue is in response to the question asked in cdancy/artifactory-rest#88 (comment)

@martinda
Copy link
Contributor Author

The find-class-gradle-plugin is proving useful to find the dependency that brings a given class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant