Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/blocker comments #403

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jutoft
Copy link
Contributor

@jutoft jutoft commented Nov 21, 2023

These changes were done to support running on bitbucket 8.x

closes #402
closes #306

@cdancy cdancy self-requested a review November 27, 2023 15:12
@cdancy
Copy link
Owner

cdancy commented Nov 27, 2023

@jutoft hey and thanks for this! Just getting back from vacation now and looking over things. Anything else we want to do here?

@jutoft
Copy link
Contributor Author

jutoft commented Nov 27, 2023

The changes works for what we use the api for. There is more deprecations, but i have not looked into them.
I have no further plans to extend the api right now.

@cdancy
Copy link
Owner

cdancy commented Nov 27, 2023

@jutoft thanks! I'll play with this a bit to make sure everything still works. This is a pretty big PR and breaking things up would certainly be better if you had the time (i.e. by feature/API) but I'll attempt to go through and see what I can make happen.

@PathParam("pullRequestId") long pullRequestId,
@Nullable @QueryParam("limit") Integer limit,
@Nullable @QueryParam("start") Integer start,
// @Nullable @QueryParam("count") Boolean count,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jutoft is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation & refactored apis for tasks Is there a plan to add a "compare" api
2 participants