Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing copyright headers on the new BCE #597

Closed
Emily-Jiang opened this issue Mar 24, 2022 · 5 comments
Closed

Missing copyright headers on the new BCE #597

Emily-Jiang opened this issue Mar 24, 2022 · 5 comments

Comments

@Emily-Jiang
Copy link
Contributor

The new classes under https://github.com/eclipse-ee4j/cdi/tree/master/api/src/main/java/jakarta/enterprise/inject/build/compatible/spi have no copyright header.

@manovotn
Copy link
Contributor

And why is that a problem? I was under the impression that we only need the license in the repo?
Lots of classes have the jboss header still which, I believe, is now not relevant either. What kind of header should be here?

@Emily-Jiang
Copy link
Contributor Author

I will find out whether it is mandatory to have the copyright headers as I have not seen Jakarta EE API classes without any copyright headers.

@pzygielo
Copy link

Perhaps https://www.eclipse.org/projects/handbook/#ip-copyright-headers is applicable

Where possible, all source code [...] should contain appropriate copyright

@Emily-Jiang
Copy link
Contributor Author

Emily-Jiang commented Mar 25, 2022

Thank you @pzygielo for the link! I talked with @ivargrimstad and he confirmed that the new classes need to have copyright headers. I guess the following copyright template might work. More details can be found from the link provided by @pzygielo

/********************************************************************************

  • Copyright (c) {year} {owner}[ and others]
  • This program and the accompanying materials are made available under the Apache Software License 2.0
  • which is available at https://www.apache.org/licenses/LICENSE-2.0.
  • SPDX-License-Identifier: Apache-2.0
    ********************************************************************************/

@starksm64
Copy link
Contributor

This has been added via #598

starksm64 added a commit that referenced this issue Mar 26, 2022
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants