New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple editions for isbn in Open Library #2

Open

cdrini opened this issue Oct 29, 2017 · 0 comments

Milestone

sync_edition_olids

Owner

cdrini commented Oct 29, 2017

openlibrary client currently returns only one edition when searching with an isbn:

openlibrary-wikidata-bot/openlibrary-wikidata-bot/jobs/sync_edition_olids.py

Line 72 in 4ecfb26

ol_books = [ol.Edition.get(isbn=isbn) for isbn in isbns]

Making the checks after this kinda useless. Try to get multiple editions.

cdrini added this to the sync_edition_olids milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment