Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing a form by email to an address containing a plus sign gets silently discarded #3636

Closed
jprince-cds opened this issue May 14, 2024 · 1 comment · Fixed by #3685
Closed

Comments

@jprince-cds
Copy link

Description

When the user wants to share their form via email, if they type an email address with a plus sign (+) as is allowed by Gmail and some other email providers, the operation appears to be successful to the user, but in the backend, the email is discarded without any notice and the email message is never sent.

Steps to reproduce

  1. Go to any form.
  2. Click on Share, then Share by email.
  3. Type an email address that is valid and which contains a +, for example assistance+forms-formulaires@cds-snc.ca
  4. Click the Send button.
  5. You get a confirmation that "The message has been sent".
  6. The message was discarded and was not sent, which is misleading to the user.

Expected behaviour

An email address with a plus sign before the @ should be accepted as valid and be processed accordingly. More-so, the Freshdesk email address for support is assistance+forms-formulaires@cds-snc.ca so users wanting to share their form with us run into this issue, which creates confusion.

Screenshots or videos

Bryan R. confirmed there is a regular expression that filters out email addresses with a + on the client side.

image.png

Additional context

Issue was uncovered while troubleshooting Freshdesk ticket 17383.

@timarney
Copy link
Member

Related PR

#3686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants